Add support for handling review comments #257
Conversation
|
Thanks for your interest in palantir/policy-bot, @jgiannuzzi! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
| @@ -548,7 +548,12 @@ func (ghc *GitHubContext) loadPagedData() error { | |||
| } | |||
|
|
|||
| for _, r := range q.Repository.PullRequest.Reviews.Nodes { | |||
| reviews = append(reviews, r.ToReview()) | |||
| switch r.State { | |||
| case "COMMENTED": | |||
There was a problem hiding this comment.
Maybe this should be case string(githubv4.PullRequestReviewStateCommented): instead?
I did not find any instance of using the githubv4 module constants anywhere in the code, and thus decided to use these strings instead, but happy to change that if you'd like.
There was a problem hiding this comment.
I think it's fine to keep these as strings for now
| switch r.State { | ||
| case "COMMENTED": | ||
| comments = append(comments, r.ToComment()) | ||
| case "APPROVED", "CHANGES_REQUESTED": |
There was a problem hiding this comment.
Same comment as above.
| @@ -548,7 +548,12 @@ func (ghc *GitHubContext) loadPagedData() error { | |||
| } | |||
|
|
|||
| for _, r := range q.Repository.PullRequest.Reviews.Nodes { | |||
| reviews = append(reviews, r.ToReview()) | |||
| switch r.State { | |||
| case "COMMENTED": | |||
There was a problem hiding this comment.
I think it's fine to keep these as strings for now
|
Hopefully we can include this in a release by the end of the week; there's one other feature currently in progress that I'd like to complete first. For now, you can test with the |
|
That would be awesome, thanks! |
This PR adds support for handling review comments like regular comments, thus allowing users to approve or disapprove without switching back to the "Conversation" tab of the pull request whilst reviewing the changes.
Fixes #51.