Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve admins and collaborators on pull requests as approval actors #48

Merged
merged 4 commits into from
Jan 23, 2019

Conversation

asvoboda
Copy link
Member

Fixes #15

@asvoboda asvoboda requested review from bluekeyes, ajlake, jmcampanini and jamestoyer and removed request for bluekeyes and ajlake January 21, 2019 15:57
Copy link
Contributor

@ferozco ferozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good!

@asvoboda
Copy link
Member Author

I guess I can't avoid cheating by force pushing against my silly formatting mistakes.

Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and looks good overall; I had some thoughts on the configuration and naming.

README.md Outdated Show resolved Hide resolved
policy/common/actor.go Outdated Show resolved Hide resolved
pull/context.go Outdated Show resolved Hide resolved
pull/context.go Outdated Show resolved Hide resolved
@asvoboda asvoboda merged commit 881a1fc into develop Jan 23, 2019
@asvoboda asvoboda deleted the as/resolve-admin branch January 23, 2019 09:28
@ferozco
Copy link
Contributor

ferozco commented Jan 23, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants