Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a server option to avoid loading pushed dates #599

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Add a server option to avoid loading pushed dates #599

merged 3 commits into from
Jul 7, 2023

Conversation

asvoboda
Copy link
Member

@asvoboda asvoboda commented Jul 7, 2023

The functionality was broken by github 2023-07-01

Partially resolves #598

@asvoboda
Add a server option to avoid loading pushed dates
fa1bb32 
The functionality was broken by github 2023-07-01
@asvoboda asvoboda requested a review from bluekeyes July 7, 2023 13:22
@asvoboda asvoboda marked this pull request as ready for review July 7, 2023 14:09
@asvoboda asvoboda requested a review from a team July 7, 2023 14:09
bluekeyes
bluekeyes approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good as a quick fix. I'm worried at some point GitHub will start rejecting queries that request this field instead of just not returning a value for it, but I guess we can deal with that when it happens if we don't have a better fix by then.

README.md Outdated Show resolved Hide resolved
asvoboda and others added 2 commits July 7, 2023 17:11
@asvoboda @bluekeyes
fix spelling mistake
3a56b52 
Co-authored-by: Billy Keyes <bkeyes@palantir.com>
@DepickereSven
feat: Add support for env (#600)
80c9333
@asvoboda
Copy link
Member Author

asvoboda commented Jul 7, 2023

Once this PR merges the feature will be available on our snapshot docker image for anyone interested in testing it out.

@asvoboda
Copy link
Member Author

asvoboda commented Jul 7, 2023

👍

@asvoboda asvoboda merged commit ba3ba7c into develop Jul 7, 2023
7 checks passed
@asvoboda asvoboda deleted the as/opt-no-load-push-date branch July 7, 2023 16:26
@zliu2-wish
Copy link

zliu2-wish commented Jul 7, 2023 •
edited

Thanks! Would we need to remove all references of invalidate_on_push: true in .policy.yml as well?

Added below to the policy-bot config under options with the new snapshot image:
do_not_load_commit_pushed_date: true

Am seeing this error:
failed to filter candidates: failed to list commits: Commit 3e0d394f79 does not have a pushed date. This is usually caused by delays in the GitHub API

(moved to issue thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agirlnamedsophia agirlnamedsophia agirlnamedsophia left review comments

@DepickereSven DepickereSven DepickereSven left review comments

@bluekeyes bluekeyes bluekeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Policy bot stuck on Commit hash does not have a pushed date
5 participants
@asvoboda @zliu2-wish @bluekeyes @agirlnamedsophia @DepickereSven