Add modified_lines predicate #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows enabling rules based on the number of lines added or deleted by a pull request. Each property takes simple expression representing a comparison and the predicate is satisfied if any expression is matched.
jmcampanini
approved these changes
Apr 19, 2019
| modified_lines: | ||
| additions: "> 100" | ||
| deletion: "> 100" | ||
| total: "> 200" |
There was a problem hiding this comment.
are all combinations of these 3 allowed?
There was a problem hiding this comment.
Yes, the code allows all combinations of the three, as there's a clear way to evaluate all of them and combine the result. That said, I'm not sure if there are any practical policies that would make use of all three in all combinations.
ajlake
reviewed
Apr 19, 2019
| return false, "", err | ||
| } | ||
| if ok { | ||
| return true, "", nil |
There was a problem hiding this comment.
It's probably worth calling out in the README that the options are combined using logical or (and not all must be true).
There was a problem hiding this comment.
The current comment says ... matches any of the listed conditions - do you think it needs to be more obvious?
Co-Authored-By: bluekeyes <bluekeyes@gmail.com>
Co-Authored-By: bluekeyes <bluekeyes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows enabling rules based on the number of lines added or deleted by a
pull request. Each property takes simple expression representing a
comparison and the predicate is satisfied if any expression is matched.
Fixes #70.