Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go-githubapp client caching #91

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Use go-githubapp client caching #91

merged 1 commit into from
Jun 24, 2019

Conversation

asvoboda
Copy link
Member

Similar in purpose to palantir/bulldozer#129

bluekeyes
bluekeyes approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will be less helpful in policy-bot than it was in Bulldozer due to the use of the v4 API. I think we'll only end up cacheing policy file lookups and the files in each PR, at least until we move file lookup to the v4 API as well.

@asvoboda asvoboda merged commit 243eef8 into develop Jun 24, 2019
@asvoboda asvoboda deleted the as/client-caching branch June 24, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluekeyes bluekeyes bluekeyes approved these changes

@jmcampanini jmcampanini Awaiting requested review from jmcampanini

@jamestoyer jamestoyer Awaiting requested review from jamestoyer

@ajlake ajlake Awaiting requested review from ajlake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asvoboda @bluekeyes