Increase the number of retries for missing dates #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally, the existing timeouts are not always sufficient. Adjust the retry loop to use exponential backoff with more attempts, resulting in a total of 15s between the first and last attempts instead of the 3s in the old implementation. Note that GitHub hooks have a 30s timeout, so we can't go too much higher on the retry counts.
ajlake
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, the existing timeouts are not always sufficient. Adjust the
retry loop to use exponential backoff with more attempts, resulting in a
total of 15s between the first and last attempts instead of the 3s in
the old implementation. Note that GitHub hooks have a 30s timeout, so we
can't go too much higher on the retry counts.