Reduce visibility of DefaultRefreshable #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
requested review from
ferozco and
carterkozak
and removed request for
fawind
carterkozak
reviewed
May 5, 2020
iamdanfox
force-pushed
the
dfox/reduce-visibility
branch
from
d9c9b41
to
01d3382
Compare
carterkozak
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We currently expose the
DefaultRefreshableclass (which is final), and also its public constructor,new DefaultRefreshable<>(foo). This is bad because it limits our ability to swap implementations under the hood if we wanted to.After this PR
==COMMIT_MSG==
The
DefaultRefreshablefinal class is no longer exposed, instead users should rely onRefreshable.createand theSettableRefreshableinterface.==COMMIT_MSG==
After merging this I'd be happy to 1.0
Possible downsides?