Fix gradle publishing to correct bintray bucket #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccheah
approved these changes
Nov 12, 2018
|
Merging ahead of finished CI because it only affects the Gradle side, and the CI has already finished the Gradle part of the build workflow. |
|
I assume this is the reason this failed, right? https://circleci.com/gh/palantir/spark/7520 |
|
Yeah |
|
Please squash the merges! Next time I will have to revoke your merge perms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We were trying to publish the gradle plugin to the wrong bintray bucket -
palantir/spark-docker-gradle(this was inferred from the gradle root project name).We've now changed that root project name to be
sparkso it will now publish to the correct bucket that the repo has credentials for.How was this patch tested?
eyeballs