Fix some 8.0 warnings #11

llorca · 2017-07-20T00:12:00Z

Warning	stylelint	'selector-no-id' has been deprecated and in 8.0 will be removed. Instead use 'selector-max-id' with '0' as its primary option. (reference)

Warning	stylelint	'selector-no-universal' has been deprecated and in 8.0 will be removed. Instead use 'selector-max-universal' with '0' as its primary option. (reference)

``` Warning stylelint 'selector-no-id' has been deprecated and in 8.0 will be removed. Instead use 'selector-max-id' with '0' as its primary option. (reference) ``` ``` Warning stylelint 'selector-no-universal' has been deprecated and in 8.0 will be removed. Instead use 'selector-max-universal' with '0' as its primary option. (reference) ```

giladgray · 2017-07-20T18:58:27Z

stylelint.config.js

-    "selector-no-id": true,
-    "selector-no-universal": true,
+    "selector-max-id": 0,
+    "selector-max-universal": 0,


i'd argue for allowing 1 universal selector to support [attribute] selectors.
for instance, blueprint disables this rule to allow such things.

giladgray approved these changes Jul 20, 2017

View reviewed changes

allow 1 universal selector

c92d147

giladgray merged commit f926bc1 into palantir:master Jul 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some 8.0 warnings #11

Fix some 8.0 warnings #11

llorca commented Jul 20, 2017

giladgray Jul 20, 2017

Fix some 8.0 warnings #11

Fix some 8.0 warnings #11

Conversation

llorca commented Jul 20, 2017

giladgray Jul 20, 2017

Choose a reason for hiding this comment