Adds key traceSampled to MDC when set trace is observable #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to 1 if observed and not present when not observed.
|
Proposed for #103 |
carterkozak
reviewed
Mar 26, 2019
|
|
||
| private static void setTraceSampledMdcIfObservable(boolean isObservable) { | ||
| if (isObservable) { | ||
| MDC.put(Tracers.TRACE_SAMPLED_KEY, "1"); |
There was a problem hiding this comment.
Might add a comment describing why we're using 1 instead of true.
| @@ -26,6 +26,7 @@ | |||
| public final class Tracers { | |||
| /** The key under which trace ids are inserted into SLF4J {@link org.slf4j.MDC MDCs}. */ | |||
| public static final String TRACE_ID_KEY = "traceId"; | |||
| public static final String TRACE_SAMPLED_KEY = "traceSampled"; | |||
There was a problem hiding this comment.
We should document this key similarly to TRACE_ID_KEY and describe possible values.
|
@uschi2000 I'm curious of your thoughts on this. |
|
Any thoughts on having the value of "0" when the trace is not sampled vs just not having the key? Would be storing more but would be more consistent with the use of the http header. |
|
On hold pending #103 (comment) |
bulldozer-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2019
…le (#144) ## Before this PR Log consumers were unable to tell which traces were sampled (observable: true) vs which traces were not sampled (observable: false). ## After this PR An MDC key traceSampled will now appear with the value "1" when the set trace has been sampled (observable: true). If the set trace is not sampled (observable: false), the key will not appear in the MDC. Note: this replaces #104
|
Closing in favor of #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Log consumers were unable to tell which traces were sampled (observable: true) vs which traces were not sampled (observable: false).
After this PR
An MDC key traceSampled will now appear with the value "1" when the set trace has been sampled (observable: true). If the set trace is not sampled (observable: false), the key will not appear in the MDC.