[improvement] Add sampled-state to filters #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raiju
changed the title
carterkozak
reviewed
Apr 17, 2019
| // Populate response before calling delegate since delegate might commit the response. | ||
| exchange.getResponseHeaders().put(TRACE_ID, traceId); | ||
| exchange.getResponseHeaders().put(IS_SAMPLED, sampled); |
There was a problem hiding this comment.
Can we create an attachment for this instead of using the response headers?
There was a problem hiding this comment.
Done. Is this how attachments should be used?
|
lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The jetty filter doesn't add the sampled state of the trace the request context.
After this PR
The jetty filter adds the sampled state to the request context, enabling e.g. logging to mark sampled traces for later inspection/filtering.