jsx-no-lambda: allow lambdas on ref attribute #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #26
The main performance drop with arrow function as prop is due to pure components re-rendering when it could be avoided. The creation of a new function is not a real problem.
The
ref
attribute is not part of the props so it's ok to use an arrow function here.See: facebook/react#9086 (comment)
Rather than adding a configuration, I simply ignore "ref" attribute. I think that this is what makes the more sense in most situations.