Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

207-Allow mutiline comment in jsx-no-multiline #247

Closed
wants to merge 1 commit into from
Closed

207-Allow mutiline comment in jsx-no-multiline #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/rules/jsxNoMultilineJsRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,17 @@ export class Rule extends Lint.Rules.AbstractRule {

function walk(ctx: Lint.WalkContext<void>): void {
return ts.forEachChild(ctx.sourceFile, function cb(node: ts.Node): void {
if (isJsxExpression(node)) {
if (isJsxExpression(node) && !isCommentBlock(node)) {
if (node.getText().indexOf("\n") > -1) {
ctx.addFailureAt(node.getStart(), node.getWidth(), Rule.FAILURE_STRING);
}
}
return ts.forEachChild(node, cb);
});
}

function isCommentBlock(node: ts.JsxExpression) {
const text = node.getText().trim();

return text.startsWith("{/*") && text.endsWith("*/}");
}
32 changes: 32 additions & 0 deletions test/rules/jsx-no-multiline-js/test.tsx.lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,35 @@ const ele = <button className={{
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
}} />;
~~ [Multiline JS expressions inside JSX are forbidden]


const ele = <div>
<div>Some Text</div>
{/* <div>
Some commented code...
</div> */}
</div>;


const ele = <div>
{/*


<div>
Some commented code...
</div>

*/}
<div>Some Text</div>
{/* <div>
Some commented code...
</div> */}
{/* <div>
Some commented code...
</div> */}
</div>;

const ele = <div>
<div>Some Text</div>
{/* */}
</div>;