Turn on strictPropertyInitialization for src/ and test/. (#3924)

Some Walker fields had to be initialized with inline initializers.
palantir · May 23, 2018 · 1f16db8 · 1f16db8
1 parent d04d026
commit 1f16db8
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/src/rules/noDuplicateVariableRule.ts b/src/rules/noDuplicateVariableRule.ts
@@ -63,7 +63,7 @@ export class Rule extends Lint.Rules.AbstractRule {
 }
 
 class NoDuplicateVariableWalker extends Lint.AbstractWalker<Options> {
-    private scope: Set<string>;
+    private scope: Set<string> = new Set();
     public walk(sourceFile: ts.SourceFile) {
         this.scope = new Set();
         const cb = (node: ts.Node): void => {

diff --git a/src/rules/noShadowedVariableRule.ts b/src/rules/noShadowedVariableRule.ts
@@ -150,7 +150,7 @@ class Scope {
 }
 
 class NoShadowedVariableWalker extends Lint.AbstractWalker<Options> {
-    private scope: Scope;
+    private scope: Scope = new Scope();
     public walk(sourceFile: ts.SourceFile) {
         if (sourceFile.isDeclarationFile) {
             return;

diff --git a/src/rules/preferConstRule.ts b/src/rules/preferConstRule.ts
@@ -121,7 +121,7 @@ interface DestructuringInfo {
 }
 
 class PreferConstWalker extends Lint.AbstractWalker<Options> {
-    private scope: Scope;
+    private scope: Scope = new Scope();
     public walk(sourceFile: ts.SourceFile) {
         // don't check anything on declaration files
         if (sourceFile.isDeclarationFile) {

diff --git a/src/tsconfig.json b/src/tsconfig.json
@@ -8,6 +8,7 @@
         "noUnusedLocals": true,
         "strictNullChecks": true,
         "strictFunctionTypes": true,
+        "strictPropertyInitialization": true,
         "importHelpers": true,
         "declaration": true,
         "sourceMap": false,

diff --git a/test/tsconfig.json b/test/tsconfig.json
@@ -8,6 +8,7 @@
         "noUnusedLocals": true,
         "strictNullChecks": true,
         "strictFunctionTypes": true,
+        "strictPropertyInitialization": true,
         "sourceMap": true,
         "target": "es5",
         "lib": ["es6"],