Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Wrong warnings in tslint.json for accepted configuration values #1776

Closed
Martin-Luft opened this issue Nov 23, 2016 · 4 comments
Closed

Wrong warnings in tslint.json for accepted configuration values #1776

Martin-Luft opened this issue Nov 23, 2016 · 4 comments
Labels

Comments

@Martin-Luft
Copy link

I'm using VSCode 1.7.2, TSLint plugin 0.6.3, TSLint 4.0.1 and TypeScript 2.0.10.

When I open the tslint.json file in VSCode I get serveral wrong warnings about my configuration values:

"cyclomatic-complexity": true, -> Incorrect type. Expected "array"

"no-consecutive-blank-lines": true, -> Incorrect type. Expected "array"

"object-literal-key-quotes": [true, "consistent-as-needed"], -> Value is not an accepted value. Valid values: [true,false,"always","as-needed"]

"one-variable-per-declaration": true, -> Incorrect type. Expected "array"

"only-arrow-functions": true, -> Incorrect type. Expected "array"

"typedef": [true, "arrow-call-signature"], -> Value is not an accepted value. Valid values: [true,false,"call-signature","parameter","arrow-parameter","property-declaration","variable-declaration","member-variable-declaration"]

https://github.com/Microsoft/vscode-tslint/issues/132

@adidahiya
Copy link
Contributor

Those don't look like errors thrown by TSLint, but rather JSON schema validation errors produced by validating against something like https://github.com/SchemaStore/schemastore/blob/54900f99ddc1870a17cc7c12492e815494deffd5/src/schemas/json/tslint.json

@Martin-Luft
Copy link
Author

@adidahiya should I open an issue there?

@egamma
Copy link

egamma commented Nov 23, 2016

@Martin-Wegner my initial analysis of your issue was not correct, sorry. What you reported are validation warnings in tslint.json reported by the vscode-tslint extension, which uses the schema mentioned #1776 (comment).

Therefore please file an issue or make a PR against the SchemaStore github repository.

@Martin-Luft
Copy link
Author

@egamma done SchemaStore/schemastore#245

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants