Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

#2036 breaks compatibility with TypeScript v2.0.10 #2054

Closed
nchen63 opened this issue Jan 16, 2017 · 3 comments · Fixed by #2055 or singapore/lint-condo#223
Closed

#2036 breaks compatibility with TypeScript v2.0.10 #2054

nchen63 opened this issue Jan 16, 2017 · 3 comments · Fixed by #2055 or singapore/lint-condo#223

Comments

@nchen63
Copy link
Contributor

nchen63 commented Jan 16, 2017

@ajafff, it looks like some of the tests fail if the user has TypeScript v2.0.10 installed. We try to maintain backwards compatibility. For example workaround code, see https://github.com/palantir/tslint/blob/master/src/rules/noInferredEmptyObjectTypeRule.ts#L56

@ajafff
Copy link
Contributor

ajafff commented Jan 16, 2017 via email

@nchen63
Copy link
Contributor Author

nchen63 commented Jan 16, 2017

Just missing lint failures. The ones below are expected by not present

test/rules/_integration/enable-disable/test.ts.lint: Failed!
Expected (from .lint file)
Actual (from TSLint)
/* tslint:enable */
var AAAaA = 'test'
    ~~~~~          [variable name must be in camelcase or uppercase]
            ~~~~~~ [' should be "]

@ajafff
Copy link
Contributor

ajafff commented Jan 16, 2017

@nchen63 I don't know how you got that output...
I only saw ts.forEachLeadingCommentRanges is not a function

however, fix is in #2055

nchen63 pushed a commit that referenced this issue Jan 18, 2017
This commit can be reverted once tslint drops support for typescript 2.0.10

Fixes #2054
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants