-
Notifications
You must be signed in to change notification settings - Fork 888
Feature Request: use node module resolution semantics for rulesDirectory #2163
Comments
With this pull request we can now write something like:
Instead of
or
This is very useful for tools which offer a |
@donaldpipowitch makes sense, that is a good motivation for making this change |
make changes based on review
make changes based on review
# This is the 1st commit message: fixes palantir#2163 make changes based on review # This is the commit message palantir#2: Fix variableNameRule compiler error
Your PR #2358 seems fine as an enhancement, but I just realized that custom rule packages really ought to configure rulesDirectory themselves so that users don't have to worry about specifying the directory -- instead, you just can just rely on |
You're right. This would work, too. But then I maybe need to overwrite the default settings. |
From buzinas/tslint-eslint-rules#214 (comment) I think the difference is this:
|
extends
uses node module resolution semantics to find files and you can specify relative paths to files, too. I'd need the same behaviour forrulesDirectory
. E.g. I want to usetslint-react/rules
which is sometimes in./node_modules/tslint-react/rules
and sometimes in../node_modules/tslint-react/rules
in my case. (I build a generic build tool configuration similar tocreate-react-app
, so I don't always have full control about the projects where my configuration is used..)The text was updated successfully, but these errors were encountered: