Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

comment-format rule "check-lowercase" option should allow whitelist of exceptions #562

Closed
adidahiya opened this issue Aug 11, 2015 · 1 comment · Fixed by singapore/lint-condo#223
Closed

comment-format rule "check-lowercase" option should allow whitelist of exceptions #562

adidahiya opened this issue Aug 11, 2015 · 1 comment · Fixed by singapore/lint-condo#223
Labels
P1 Resolution: Fixed Type: Enhancement

Comments

@adidahiya
Copy link
Contributor

I'd like to allow exceptions to the check-lowercase rule option via a whitelist that looks something like:

"comment-format": [true,
    ["check-lowercase", "TODO", "HACKHACK"],
    "check-space"
]
@adidahiya adidahiya changed the title comment-format check-lowercase should allow TODO comments comment-format rule "check-lowercase" option should allow whitelist of exceptions Aug 26, 2015
@adidahiya adidahiya added P1 and removed P2 labels Aug 26, 2015
@jkillian jkillian mentioned this issue Sep 1, 2015
Closed
@IllusionMH
Copy link
Contributor

As I can see format with nested arrays isn't supported in system.
What about optional array of whitelisted words as last argument?

IllusionMH added a commit to IllusionMH/tslint that referenced this issue Nov 20, 2016
@IllusionMH
Add exceptions support for comment-format rule (fixes palantir#562)
5df075a
@IllusionMH IllusionMH mentioned this issue Nov 20, 2016
Merged
4 tasks
IllusionMH added a commit to IllusionMH/tslint that referenced this issue Dec 11, 2016
@IllusionMH
Add support for RexExp pattern in comment-format rule exceptions (fixes
3d6ccef 
palantir#562)
IllusionMH added a commit to IllusionMH/tslint that referenced this issue Jan 7, 2017
@IllusionMH
Add exceptions support for comment-format rule (fixes palantir#562)
f8c43dc
IllusionMH added a commit to IllusionMH/tslint that referenced this issue Jan 7, 2017
@IllusionMH
Add support for RexExp pattern in comment-format rule exceptions (fixes
c8a03f4 
palantir#562)
@nchen63 nchen63 closed this as completed in 11d1281 Jan 8, 2017
@keylocation-bot keylocation-bot mentioned this issue Jan 25, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1 Resolution: Fixed Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependency tslint to version 4.4.2 singapore/lint-condo
3 participants
@adidahiya @IllusionMH @jkillian