This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add new rule to enforce headers matched by regexp #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Checks for comments at the very beginning of files - Ignores #! - Matches comment contents with header regexp
| export class Rule extends Lint.Rules.AbstractRule { | ||
| /* tslint:disable:object-literal-sort-keys */ | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "enforce-header", |
There was a problem hiding this comment.
can we call this rule "file-header" instead? "enforce" is a little redundant because all our rules enforce something.
|
overall looks pretty good, just left minor comments. @jkillian can you also take a look? |
- Renamed folders and files - Fixed syntax bug in tests
|
Looks fine to me, thanks @ScottSWu! |
soniro
pushed a commit
to soniro/tslint
that referenced
this pull request
Aug 31, 2016
…ntir#1441) - Checks for comments at the very beginning of files - Ignores #! - Matches comment contents with header regexp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #155
cc: @alexeagle