This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fixes for no-shadowed-variable rule #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IllusionMH re: multiple fixes in one PR -- use your discretion. if they're related fixes then 👍 |
…antir#1258)" This reverts commit 759be68.
|
I've reverted previous commit because there is better way to skip index signatures which is similar to other cases. Also added few test cases for index signatures. Also added fix for #1099 to this PR since it is similar to function types (was implemented previously) and index signatures. |
|
Looks good to me, thanks @IllusionMH! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258
Also I'm working on fix for #1099. Is it appropriate to send several fixes for one rule in one PR?