-
Notifications
You must be signed in to change notification settings - Fork 889
Conversation
6eac039
to
32ab09a
Compare
@@ -174,7 +174,7 @@ function resolveConfigurationPath(filePath: string, relativeTo?: string) { | |||
} catch (err) { | |||
try { | |||
return require.resolve(filePath); | |||
} catch (err) { | |||
} catch (anotherErr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably add some options to ignore catched exceptions and maybe variable names matching a regex. That way you don't need a new name for nested try...catch blocks or errorback style callbacks
public createScope() { | ||
return new Set(); | ||
} | ||
class Walker extends Lint.AbstractWalker<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't get me wrong, but to me this implementation seems to be overly complex for this use case.
Do you mind if I try to come up with a simpler approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Be sure to test for type parameters, namespaces, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajafff Bump
@andy-hanson thanks for the reminder and sorry for the delay. I'll have time to look into this early next week. Should be ready no later than on tuesday. |
closing in favor of #2598 |
PR checklist
Overview of change:
Complete rewrite of
no-shadowed-variable
.Now checks for shadowing of types too (e.g.
interface Foo { m<Foo>(): Foo }
).Also now no ignores variables named 'this'.