This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
no-unsafe-any: Allow import declarations #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Apr 5, 2017
| @@ -1,3 +1,10 @@ | |||
| import importEquals = require("./commonjsModule"); | |||
| import importAlias = modA; | |||
| import importQualifiedName = N.x; | ||
| import * as namespaceImport from "./commonjsModule"; | ||
| import defaultExport, { namedExport } from "./es6Module"; | ||
|
|
There was a problem hiding this comment.
you should add a test to ensure that using imported variables like defaultExport or namedExport in property access etc. still results in an error
src/rules/noUnsafeAnyRule.ts
Outdated
| @@ -91,10 +97,12 @@ function isAllowedLocation(node: ts.Expression, { getContextualType, getTypeAtLo | |||
| return false; | |||
There was a problem hiding this comment.
you probably need to add a case for CommaToken
src/rules/noUnsafeAnyRule.ts
Outdated
| @@ -47,14 +47,13 @@ export class Rule extends Lint.Rules.TypedRule { | |||
| const isExpression: (node: ts.Node) => node is ts.Expression = (ts as any).isExpression; | |||
|
|
|||
| function walk(ctx: Lint.WalkContext<void>, checker: ts.TypeChecker): void { | |||
| return ts.forEachChild(ctx.sourceFile, recur); | |||
| function recur(node: ts.Node): void { | |||
| return ts.forEachChild(ctx.sourceFile, function cb(node: ts.Node): void { | |||
| if (isExpression(node) && isAny(checker.getTypeAtLocation(node)) && !isAllowedLocation(node, checker)) { | |||
There was a problem hiding this comment.
I think it would increase performance if you swap the calls to isAny(...) and isAllowedLocation(...)
blakeembrey
added a commit
to blakeembrey/tslint-config-standard
that referenced
this pull request
Apr 5, 2017
andy-hanson
force-pushed
the
no-unsafe-any_import
branch
2 times, most recently
from
761e596
to
caba22c
Compare
|
Did a complete rewrite. I also have a branch testing out applying the rule to tslint itself, but that will have to wait until the fixes are published globally (else |
andy-hanson
force-pushed
the
no-unsafe-any_import
branch
from
caba22c
to
b86de64
Compare
Merged
nchen63
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Always allow import statements in
no-unsafe-any.CHANGELOG.md entry:
[bugfix]
no-unsafe-any: Allow import declarations