This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Added "check-type-list" as option to whitespace rule #2884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'll now check whitespace around the operators in syntax lists (`|` and `&`). Fixes #2818. Also changed references to the const options to use the actual option variable and alphabetized the listings. Figured it'd be a little cleaner this way. The `maxLength` for options was listed at 7 despite there originally being 8 options (any particular reason?), so I bumped it to 9 for this 9th option.
ajafff
approved these changes
Jun 4, 2017
4 tasks
|
Fixes #488 |
ajafff
suggested changes
Aug 1, 2017
| @@ -96,6 +100,11 @@ function walk(ctx: Lint.WalkContext<Options>) { | |||
| checkEqualsGreaterThanTokenInNode(node); | |||
| break; | |||
|
|
|||
| case ts.SyntaxKind.IntersectionType: | |||
| case ts.SyntaxKind.UnionType: | |||
| checkTypeJoin(node.getChildren()[0] as ts.SyntaxList); | |||
There was a problem hiding this comment.
Needs to check if the option is enabled.
2 tasks
|
Closing this, because #3083 was merged with the same functionality. |
|
Ah, I took too long. Thanks anyway :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'll now check whitespace around the operators in syntax lists (
|and&).Fixes #2818.
PR checklist
Overview of change:
Also changed references to the const options to use the actual option variable and alphabetized the listings. Figured it'd be a little cleaner this way.
The
maxLengthfor options was listed at 7 despite there originally being 8 options (any particular reason?), so I bumped it to 9 for this 9th option.CHANGELOG.md entry:
[enhancement] Added type list checking to
whitespace