This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Update to typescript@2.5.1 #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Update to the new version of typescript and fix all new errors.
Unfortunately
moduleNameHasNonRelativeNameis no longer exposed which would break the build. We can either wait for microsoft/TypeScript#17890 to be fixed in the next patch release or merge as is and remove the assertion innoSubmoduleImportsRulelater.Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[bugfix]
prefer-constcorrectly handlecatchwithout binding parameter introduced intypescript@2.5.1Fixes #3154