This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[new-rule-option] [object-literal-sort-key] Add shorthand-first option #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @brunolemos! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Fix palantir#3606 (Conflict between object-shorthand-properties-first and object-literal-sort-key)
brunolemos
force-pushed
the
object-literal-sort-key-shorthand-first
branch
from
f2640a2
to
7b1223e
Compare
ajafff
approved these changes
Dec 26, 2017
|
@ajafff any thing I should do before merge? thanks |
|
Thanks @brunolemos |
|
@ajafff awesome, thanks 🙌 |
|
Just tested on a real project, works great. In case someone get here, depending on your "object-literal-sort-keys": [true, "shorthand-first"],
"object-shorthand-properties-first": false, |
adidahiya
reviewed
Jan 8, 2018
brunolemos
added a commit
to brunolemos/tslint-config-airbnb
that referenced
this pull request
Jan 15, 2018
…-sort-key # `shorthand-first` is available since tslint v5.9.0. See: palantir/tslint#3606 and palantir/tslint#3607
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3606
Similar to PR #2831 but different implementation and focused only on shorthand-first
PR checklist
Overview of change:
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[new-rule-option] [object-literal-sort-key] Add shorthand-first option