fix no unnecessary space before parameter from arrow-parens fixer #3618
Conversation
| @@ -38,3 +40,4 @@ let foo = bar => bar; | |||
|
|
|||
| let foo = async bar => bar; | |||
|
|
|||
| arr.map(a => b); | |||
There was a problem hiding this comment.
this will probably fail for foo(async (a) => b) by fixing it to foo(asyca => b)
src/rules/arrowParensRule.ts
Outdated
| @@ -72,8 +72,10 @@ function walk(ctx: Lint.WalkContext<Options>) { | |||
| } | |||
| } else if (ctx.options.banSingleArgParens) { | |||
| const closeParen = getChildOfKind(node, ts.SyntaxKind.CloseParenToken)!; | |||
| const parentNode = node.parent!; | |||
| const replaceValue = ts.isCallExpression(parentNode) ? "" : " "; | |||
There was a problem hiding this comment.
This should not be limited to CallExpressions. This is also relevant for NewExpression and probably many other.
I propose to remove the blank all the time if there is no alpha character at openParen.pos - 1. That includes async (a) => b and export default (a) => b.
Another rule will probably complain about a missing blank, but that's not the business of this rule.
…er or assignment before opening paren
|
@ajafff I've updated my PR. Apart from checking for alpha characters fixer checks also assignemnt character. Otherwise it would fix |
src/rules/arrowParensRule.ts
Outdated
| @@ -72,8 +72,10 @@ function walk(ctx: Lint.WalkContext<Options>) { | |||
| } | |||
| } else if (ctx.options.banSingleArgParens) { | |||
| const closeParen = getChildOfKind(node, ts.SyntaxKind.CloseParenToken)!; | |||
| const charBeforeOpenParen = ctx.sourceFile.text.substring(openParen.pos - 1, openParen.pos); | |||
| const replaceValue = charBeforeOpenParen.match(/[a-z=]/i) !== null ? " " : ""; | |||
There was a problem hiding this comment.
I don't think this rule should do anything related to code formatting. It adds the space only where strictly necessary to avoid invalid syntax.
Everything else assumes a certain style preference of the user, that this rule cannot know.
Anyways, if you really want to add a space after = you should probably also add one after
,as infoo(bar, (a) => b)?and:as infoo ? (a) => b : (a) => c&and|as insomeFn || (a) => b- maybe more
There was a problem hiding this comment.
I think you're right about unnecessary code formatting here. I'll change it and adjust test cases accordingly.
| arr.map((a) => b); | ||
| ~ [0] | ||
|
|
||
| foo(async (a) => b) |
There was a problem hiding this comment.
can you please add some more tests like
function *gen() { yield (a) => b; }
export default (a) => b;
throw (a) => b; // hopefully nobody ever does this… if it's required by syntax
|
Thanks @mateuszwitkowski |
PR checklist
Overview of change:
Fixer for ban-single-arg-parens doesn't add unnecessary whitespace before argument if parent node is a call expresion.
CHANGELOG.md entry:
[bugfix] no unnecessary whitespace before argument in callback functions fixed with arrow-parens fixer