This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Reduce false positive rate in no-invalid-template-strings #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this? The testNext failure looks unrelated to this change. |
giladgray
approved these changes
May 1, 2018
|
Looks like the build is still failing. Still appears unrelated to this PR |
|
Any thoughts on this? |
|
Hi @mitchellwills, I think if you merge master into your branch one more time this should fix the tests. Once you have done so, please tag me and I'll merge it for you |
Don't flag unmatched ${ in a regular string
Also flag the entire expression, not just the opening brace
|
@johnwiseheart looks like all the tests are passing now |
|
Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
CHANGELOG.md entry:
[enhancement] Don't flag unmatched ${ in no-invalid-template-strings