New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo repo #42
Merged
Merged
Redo repo #42
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c501c2b
Redo repo
themadcreator d662648
Adding tslint rules from blueprint and fixing lint errors
themadcreator aef0219
Adding coverage checks
themadcreator aaaeaf2
Removing unnecessary nesting of tests directories. Fixing coverage
themadcreator 6c2dc77
Add license header to all source files
themadcreator e68faee
Go full module mode. Update typedoc generation
themadcreator 8ec94d4
Add dev preview. Fix whitespace issue.
themadcreator 3aa6f12
Adding docs and dev preview to commits and PRs
themadcreator e28a4a6
Fixing scripts
themadcreator d25174f
Add artifacts to make previews visible
themadcreator a6dd66f
Fix title of dev preview page
themadcreator b51dfdc
Use modern node versions. Add saucelabs crossbrowser tests
themadcreator 70400b9
Kick build
themadcreator 9c71190
Test command syntax
themadcreator 0fd2405
Use npmignore whitelist. Change d3 types versions. Remove es6-shim
themadcreator File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
check: | ||
each: | ||
statements: 90 | ||
lines: 90 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"sauceLabs": true, | ||
"hostname": "localhost", | ||
"port": 8081, | ||
"testname": "SVGTypewriter Sauce Unit Tests", | ||
"browsers": [{ | ||
"name": "firefox", | ||
"platform": "linux" | ||
}, { | ||
"name": "chrome", | ||
"platform": "linux" | ||
}, { | ||
"name": "internet explorer", | ||
"platform": "Windows 10", | ||
"version": "11.103" | ||
}, { | ||
"name": "MicrosoftEdge", | ||
"platform": "Windows 10", | ||
"version": "14.14393" | ||
}, { | ||
"name": "safari", | ||
"platform": "OS X 10.10", | ||
"version": "8" | ||
}] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,11 @@ | ||
build/ | ||
bower_components/ | ||
docs/ | ||
src/ | ||
test/ | ||
typings/ | ||
bower.json | ||
circle.yml | ||
Gruntfile.js | ||
index.html | ||
index.js | ||
license_header.txt | ||
tsd.json | ||
tslint.json | ||
**/* | ||
!README.md | ||
!LICENSE | ||
!package.json | ||
|
||
# include source typescript | ||
!src/**/* | ||
|
||
# include compiled javascript, sourcemaps, and declarations | ||
!build/src/**/* | ||
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we now include these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all
*.yml
files are now ignored.it would be safer to write this file like https://github.com/palantir/plottable/blob/develop/.npmignore, which whitelists files in the package rather than blacklists them, but we don't do that consistently everywhere (blueprint doesn't do it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice