Rename variables to more descriptive versions

palantirnet · Aug 22, 2023 · 0ac14fa · 0ac14fa
1 parent d1234a8
commit 0ac14fa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/Rector/Deprecation/DrupalServiceRenameRector.php b/src/Rector/Deprecation/DrupalServiceRenameRector.php
@@ -43,8 +43,8 @@ public function refactor(Node $node) {
                         /* @var Node\Arg $argument */
                         $argument = $node->args[0];
 
-                        if ($argument->value instanceof Node\Scalar\String_ && $argument->value->value === $configuration->getOldArgument()) {
-                            $node->args[0] = new Node\Arg(new Node\Scalar\String_($configuration->getNewArgument()));
+                        if ($argument->value instanceof Node\Scalar\String_ && $argument->value->value === $configuration->getDeprecatedService()) {
+                            $node->args[0] = new Node\Arg(new Node\Scalar\String_($configuration->getNewService()));
 
                             return $node;
                         }

diff --git a/src/Rector/ValueObject/DrupalServiceRenameConfiguration.php b/src/Rector/ValueObject/DrupalServiceRenameConfiguration.php
@@ -3,20 +3,20 @@
 namespace DrupalRector\Rector\ValueObject;
 
 class DrupalServiceRenameConfiguration {
-    protected string $newArgument;
+    protected string $newService;
 
-    protected string $oldArgument;
+    protected string $deprecatedService;
 
-    public function __construct(string $oldArgument, string $newArgument) {
-        $this->oldArgument = $oldArgument;
-        $this->newArgument = $newArgument;
+    public function __construct(string $deprecatedService, string $newService) {
+        $this->deprecatedService = $deprecatedService;
+        $this->newService = $newService;
     }
-    public function getNewArgument(): string {
-        return $this->newArgument;
+    public function getNewService(): string {
+        return $this->newService;
     }
 
-    public function getOldArgument(): string {
-        return $this->oldArgument;
+    public function getDeprecatedService(): string {
+        return $this->deprecatedService;
     }
 
 }