New rector (10.3): Add rule for file_icon_class() and file_icon_map() #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now its ok to add those errors in phpstan to the baseline, we'll need to fix those, so perhaps a followup on the main issue on d.o. is good :) |
bbrala
approved these changes
Jun 7, 2024
bbrala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
file_icon_class()andfile_icon_map()are deprecated and replaced with static methods on\Drupal\file\IconMimeTypes. I've used the existingFunctionToStaticConfigurationto replace the deprecated functions.@bbrala mentioned that
stubs/Drupal/Drupal.phpshould be upped to10.99.x-devbecause we always need to run the tests in this major.To Test
composer testDrupal.org issue
https://www.drupal.org/project/rector/issues/3450324
https://www.drupal.org/node/3411269