Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add whole buffer object binding #12

Merged
merged 1 commit into from May 4, 2016
Merged

add whole buffer object binding #12

merged 1 commit into from May 4, 2016

Conversation

d12frosted
Copy link
Contributor

Just as title says, now there is B binding to operate on whole buffer. In case I missed something, just let me know.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.321% when pulling 75674ee on d12frosted:features/mark-whole-buffer into 3217f3d on paldepind:master.

@paldepind
Copy link
Owner

Really great 👍 I've been thinking about this myself.

I'm not sure about the binding though. B requires a modifier, and there are still many keys available that does not. I can see that it has mnemonic value. But I'm thinking that using something that is easier to press might be better. For instance u for buffer. What do you think?

@d12frosted
Copy link
Contributor Author

Ya, was thinking about the same. Already using B and doesn't quite like it. But I do like u for that. Pretty mnemonic. Would you like me to update key binding or will you do it?

@paldepind
Copy link
Owner

Please update it and then I'll merge it in 😄

This is also consistent with y for symbol.

@d12frosted
Copy link
Contributor Author

Please update it and then I'll merge it in 😄

Done.

This is also consistent with y for symbol.

Indeed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.321% when pulling d6df86a on d12frosted:features/mark-whole-buffer into 3217f3d on paldepind:master.

@paldepind
Copy link
Owner

Splendid. Thank you for this contribution.

@paldepind paldepind merged commit 3397b35 into paldepind:master May 4, 2016
@d12frosted
Copy link
Contributor Author

You're welcome :)

Thank you for this package :)

~ d12frosted

On Wed, May 4, 2016 at 8:14 PM, Simon Friis Vindum <notifications@github.com

wrote:

Merged #12 #12.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12 (comment)

@d12frosted d12frosted deleted the features/mark-whole-buffer branch May 5, 2016 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants