Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws 0.7.0 dependency doesn't work with node 5.1? #8

Closed
arlair opened this issue Nov 29, 2015 · 4 comments
Closed

ws 0.7.0 dependency doesn't work with node 5.1? #8

arlair opened this issue Nov 29, 2015 · 4 comments

Comments

@arlair
Copy link

arlair commented Nov 29, 2015

Just letting you know I had to change this because bufferutil 1.1.x does not seem to compile in Node 5.1 (and sounds like maybe 4.* from other comments I saw, but not definite about that)

I used 0.8.0 and it compiled.

I think it was in two of the synceddb packages.

@piglovesyou
Copy link
Collaborator

I pass all tests with ws 0.7.0 and node v5.8.0. Weird.

But we should use ws v1.0.0 or later that seems more stable.

@piglovesyou
Copy link
Collaborator

piglovesyou commented Jun 12, 2016

I reproduced. Something wrong with one published on npm?

All log on gist

piglovesyou added a commit that referenced this issue Jun 12, 2016
@piglovesyou
Copy link
Collaborator

CI needs another module to be set

piglovesyou added a commit that referenced this issue Jun 12, 2016
@piglovesyou
Copy link
Collaborator

@arlair Thank you for the report.

@paldepind, We need to publish synceddb-server with the newer dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants