Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types in the package #35

Closed
mathieutu opened this issue Nov 4, 2022 · 1 comment
Closed

Add types in the package #35

mathieutu opened this issue Nov 4, 2022 · 1 comment

Comments

@mathieutu
Copy link
Contributor

Hey, thanks for your work!

Is your feature request related to a problem? Please describe.
Your package is written is TS.
The package.json had a types entry to dist/index.d.ts but this file doesn't exist.

I would be quite handy to have them to be able to import and use the methods directly.

Describe the solution you'd like

- "declaration": false,
+ "declaration": true, 

in tsconfig.build.json

Describe alternatives you've considered
🤷
Additional context
Happy to do the PR.
Thanks!

@paleite
Copy link
Owner

paleite commented Nov 7, 2022

Hi, good idea!
Please do the PR if you have the time, otherwise I will be able to do it myself fairly soon.

Thanks for the suggestion

paleite added a commit that referenced this issue May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants