Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeout_ms #83

merged 2 commits into from Dec 12, 2022

Remove timeout_ms #83

merged 2 commits into from Dec 12, 2022


Copy link

@palfrey palfrey commented Dec 12, 2022

As noted in #79, timeout_ms is quite frankly confusing, doesn't do what people expect it to (set a timeout on a function) and also doesn't reliably do what I originally wanted it to do (detect test locks and timeout).

This PR therefore removes the whole thing.

@palfrey palfrey merged commit cb516b9 into main Dec 12, 2022
7 checks passed
@palfrey palfrey deleted the remove-timeout branch December 12, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant