Skip to content

Commit

Permalink
PVRIptpData: Provide channel ID in recordings
Browse files Browse the repository at this point in the history
  • Loading branch information
palinek committed Feb 18, 2019
1 parent 7995ea3 commit dbb8825
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pvr.sledovanitv.cz/addon.xml.in
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<addon
id="pvr.sledovanitv.cz"
version="1.4.8"
version="1.4.9"
name="PVR Client for sledovanitv.cz (unofficial)"
provider-name="palinek">
<requires>@ADDON_DEPENDS@</requires>
Expand Down
2 changes: 2 additions & 0 deletions src/PVRIptvData.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,7 @@ bool PVRIptvData::LoadRecordings()
if (channel_i != channels->cend())
{
iptvrecording.strChannelName = channel_i->strChannelName;
iptvrecording.iChannelUid = channel_i->iUniqueId;
}
iptvrecording.startTime = startTime;
iptvrecording.strPlotOutline = record.get("event", "").get("description", "").asString();
Expand Down Expand Up @@ -1029,6 +1030,7 @@ PVR_ERROR PVRIptvData::GetRecordings(ADDON_HANDLE handle)
strAssign(xbmcRecord.strPlot, rec.strPlotOutline);
xbmcRecord.iDuration = rec.duration;
xbmcRecord.iLifetime = rec.iLifeTime;
xbmcRecord.iChannelUid = rec.iChannelUid;

This comment has been minimized.

Copy link
@ksooo

ksooo Feb 18, 2019

Collaborator

Looking at the code here
dbb8825#diff-566f01fa716ca5936070764622eb57a2R541 (conditional assignment)

and here

dbb8825#diff-91950a50dcbbd807c8a46a00395cdc3cR100 (no init)

I wonder whether you can end up with a random value here?

This comment has been minimized.

Copy link
@palinek

palinek Feb 18, 2019

Author Owner

You're right. What should be the default (unknown) value? 0?

This comment has been minimized.

This comment has been minimized.

Copy link
@palinek

palinek Feb 18, 2019

Author Owner

OK. Thanks. Done in 19c59c6

This comment has been minimized.

Copy link
@ksooo

ksooo Feb 18, 2019

Collaborator

👍

xbmcRecord.channelType = rec.bRadio ? PVR_RECORDING_CHANNEL_TYPE_RADIO : PVR_RECORDING_CHANNEL_TYPE_TV;

xbmc_records.push_back(std::move(xbmcRecord));
Expand Down
1 change: 1 addition & 0 deletions src/PVRIptvData.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ struct PVRIptvRecording
bool bRadio;
int iLifeTime;
std::string strStreamType;
int iChannelUid;
};

struct PVRIptvTimer
Expand Down

0 comments on commit dbb8825

Please sign in to comment.