Added with_context qualifier to have_authorized_scope matcher

[killondark]

Hi @palkan. I added with_context qualifier to have_authorized_scope matcher
Discussed in #258

PR checklist:

• Tests included
• Documentation updated

[coveralls-official]

coverage: 93.639% (+0.05%) from 93.587%
when pulling 86d553e on killondark:add-with_context-to-have_authorized_scope
into 8e69239 on palkan:master.

[palkan]

Thanks!

Left some comments, please, take a look.

[palkan]

We should use the same logic here as for authorization calls:

action_policy/lib/action_policy/testing.rb

Lines 29 to 33 in 8e69239

	def context_matches?(context, actual)
	return true unless context
	context === actual || actual >= context
	end

It covers subsets and RSpec composable matchers.

[palkan]

The default MUST be nil (meaning that we don't want to verify context)

[palkan]

We already have policy in the state, no need to extract context into its own instance variable.

[palkan]

A context is usually a record (it's an acting subject); it's unlikely a bool. Let's change this example:

Suggested change

	def favorite
	authorized_scope(User.all, context: {favorite: true})
	end
	def for_user
	user = User.find(params[:id])
	authorized_scope(User.all, context: {user:})
	end

[palkan]

Suggested change

	expect { get :favorite }.to have_authorized_scope(:scope)
	.with_scope_options(matching(with_deleted: a_falsey_value))
	.with_context(favorite: true)
	expect { get :for_user, params: {id: user.id} }.to have_authorized_scope(:scope)
	.with_scope_options(matching(with_deleted: a_falsey_value))
	.with_context(a_hash_including(user:))

[killondark]

Thanks for your comments. Corrected. Please check it.

[killondark]

Hi @palkan. Have you seen my latest fixes?

[palkan]

Thanks!

[palkan]

We cannot use #blank? here, we have no dependency on Active Support core extensions (I'll fix it).