Skip to content

Commit

Permalink
style: upgrade rubocop
Browse files Browse the repository at this point in the history
  • Loading branch information
palkan committed Sep 15, 2023
1 parent acf61f9 commit 4f0d9e5
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions lib/logidze/utils/check_pending.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

require_relative "./function_definitions"
require_relative "./pending_migration_error"
require_relative "function_definitions"
require_relative "pending_migration_error"

module Logidze
module Utils
Expand Down
2 changes: 1 addition & 1 deletion spec/dummy/app/models/comment.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

class Comment < ActiveRecord::Base
has_logidze ignore_log_data: false
belongs_to :article
belongs_to :article, touch: true
end
22 changes: 11 additions & 11 deletions spec/generators/model_generator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ class User < ActiveRecord::Base
is_expected.to exist
is_expected.to contain "ActiveRecord::Migration[#{ar_version}]"
is_expected.to contain "add_column :users, :log_data, :jsonb"
is_expected.to contain(/create trigger "logidze_on_#{full_table_name('users')}"/i)
is_expected.to contain(/before update or insert on "#{full_table_name('users')}" for each row/i)
is_expected.to contain(/create trigger "logidze_on_#{full_table_name("users")}"/i)
is_expected.to contain(/before update or insert on "#{full_table_name("users")}" for each row/i)
is_expected.to contain(/execute procedure logidze_logger\(null, 'updated_at'\);/i)
is_expected.to contain(/drop trigger if exists "logidze_on_#{full_table_name('users')}" on "#{full_table_name('users')}"/i)
is_expected.not_to contain(/update "#{full_table_name('users')}"/i)
is_expected.to contain(/drop trigger if exists "logidze_on_#{full_table_name("users")}" on "#{full_table_name("users")}"/i)
is_expected.not_to contain(/update "#{full_table_name("users")}"/i)

expect(file("app/models/user.rb")).to contain "has_logidze"
end
Expand Down Expand Up @@ -120,7 +120,7 @@ class User < ActiveRecord::Base

it "creates backfill query" do
is_expected.to exist
is_expected.to contain(/update "#{full_table_name('users')}" as t/i)
is_expected.to contain(/update "#{full_table_name("users")}" as t/i)
is_expected.to contain(/set log_data = logidze_snapshot\(to_jsonb\(t\), 'updated_at'\);/i)
end
end
Expand All @@ -131,10 +131,10 @@ class User < ActiveRecord::Base
it "creates migration with trigger" do
is_expected.to exist
is_expected.not_to contain "add_column :users, :log_data, :jsonb"
is_expected.to contain(/create trigger "logidze_on_#{full_table_name('users')}"/i)
is_expected.to contain(/before update or insert on "#{full_table_name('users')}" for each row/i)
is_expected.to contain(/create trigger "logidze_on_#{full_table_name("users")}"/i)
is_expected.to contain(/before update or insert on "#{full_table_name("users")}" for each row/i)
is_expected.to contain(/execute procedure logidze_logger\(null, 'updated_at'\);/i)
is_expected.to contain(/drop trigger if exists "logidze_on_#{full_table_name('users')}" on "#{full_table_name('users')}"/i)
is_expected.to contain(/drop trigger if exists "logidze_on_#{full_table_name("users")}" on "#{full_table_name("users")}"/i)
is_expected.not_to contain "remove_column :users, :log_data"
end
end
Expand All @@ -150,8 +150,8 @@ class User < ActiveRecord::Base
it "creates migration with drop and create trigger" do
is_expected.to exist
is_expected.not_to contain "add_column :users, :log_data, :jsonb"
is_expected.to contain(/drop trigger if exists "logidze_on_#{full_table_name('users')}" on "#{full_table_name('users')}"/i)
is_expected.to contain(/before update or insert on "#{full_table_name('users')}" for each row/i)
is_expected.to contain(/drop trigger if exists "logidze_on_#{full_table_name("users")}" on "#{full_table_name("users")}"/i)
is_expected.to contain(/before update or insert on "#{full_table_name("users")}" for each row/i)
is_expected.to contain "raise ActiveRecord::IrreversibleMigration"
end

Expand Down Expand Up @@ -224,7 +224,7 @@ class User < ActiveRecord::Base

it "use after trigger" do
is_expected.to exist
is_expected.to contain(/after update or insert on "#{full_table_name('users')}" for each row/i)
is_expected.to contain(/after update or insert on "#{full_table_name("users")}" for each row/i)
is_expected.to contain(/execute procedure logidze_logger_after\(null, 'updated_at'\);/i)
end

Expand Down

0 comments on commit 4f0d9e5

Please sign in to comment.