Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to version 0.69.0 #25

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented May 14, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.61.0 → ~> 0.69.0) · Repo · Changelog

Release Notes

0.69.0

New features

  • Add support for subclassing using Class.new to Lint/InheritException. (@houli)
  • #6779: Add new cop Style/NegativeUnless that checks for unless with negative condition. (@tejasbubane)

Bug fixes

  • #6900: Fix Rails/TimeZone autocorrect Time.current to Time.zone.now. (@vfonic)
  • #6900: Fix Rails/TimeZone to prefer Time.zone.#{method} over other acceptable corrections. (@vfonic)
  • #7007: Fix Style/BlockDelimiters with braces_for_chaining style false positive, when chaining using safe navigation. (@Darhazer)
  • #6880: Fix .rubocop file parsing. (@hoshinotsuyoshi)
  • #5782: Do not autocorrect Lint/UnifiedInteger if TargetRubyVersion < 2.4. (@lavoiesl)
  • #6387: Prevent Lint/NumberConversion from reporting error with Time/DateTime. (@tejasbubane)
  • #6980: Fix Style/StringHashKeys to allow string as keys for hash arguments to gsub methods. (@tejasbubane)
  • #6969: Fix a false positive with block methods in Style/InverseMethods. (@dduugg)
  • #6729: Handle array spread for change_column_default in Rails/ReversibleMigration cop. (@tejasbubane)
  • #7033: Fix an error for Layout/EmptyLineAfterGuardClause when guard clause is a ternary operator. (@koic)

Changes

  • #6945: Drop support for Ruby 2.2. (@koic)
  • #6945: Set default EnforcedStyle to squiggly option for Layout/IndentHeredoc and auto_detection option is removed. (@koic)
  • #6945: Set default EnforcedStyle to always option for Style/FrozenStringLiteralComment and when_needed option is removed. (@koic)
  • #7027: Allow unicode/display_width dependency version 1.6.0. (@tagliala)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 37 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 14, 2019
@palkan
Copy link
Owner

palkan commented May 14, 2019

@​depfu pause

@palkan palkan closed this May 14, 2019
@depfu
Copy link
Author

depfu bot commented May 14, 2019

Pausing rubocop updates for all future versions. Go to your Depfu dashboard or use the @depfu resume command to resume updates.

@depfu depfu bot deleted the depfu/update/rubocop-0.69.0 branch May 14, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant