fix: #parameterize != #underscore

palkan · Aug 16, 2023 · d1cdeea · d1cdeea
1 parent c3e2218
commit d1cdeea
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/ruby_bytes/thor.rb b/lib/ruby_bytes/thor.rb
@@ -20,7 +20,7 @@ def template(url)
     # TODO: Add more extensions
     class ::String
       def parameterize
-        gsub("::", "/").gsub(/([a-z])([A-Z])/, '\1-\2').downcase
+        downcase.gsub(/[^a-z0-9\-_]+/, '-').gsub(/-{2,}/, '-').gsub(/^-|-$/, '')
       end
 
       def underscore

diff --git a/templates/rbytes/core_ext.rb b/templates/rbytes/core_ext.rb
@@ -7,7 +7,7 @@
   # TODO: Add more extensions
   class ::String
     def parameterize
-      gsub("::", "/").gsub(/([a-z])([A-Z])/, '\1-\2').downcase
+      downcase.gsub(/[^a-z0-9\-_]+/, '-').gsub(/-{2,}/, '-').gsub(/^-|-$/, '')
     end
 
     def underscore

diff --git a/test/integration_test.rb b/test/integration_test.rb
@@ -106,7 +106,7 @@ def test_dummy_rails
     run_generator do |output|
       assert_line_printed(
         output,
-        "APP=robo-bytes"
+        "APP=robobytes"
       )
     end
   end