forked from apache/falcon
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
FALCON-2200 Incorporated review comments. Moved common code from prox…
…ies to proxyutil and making 2 api calls to get location in case of update extension
- Loading branch information
1 parent
c8d0ab7
commit 8a4d035
Showing
6 changed files
with
209 additions
and
210 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150 changes: 150 additions & 0 deletions
150
prism/src/main/java/org/apache/falcon/resource/proxy/EntityProxyUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.falcon.resource.proxy; | ||
|
|
||
| import org.apache.falcon.FalconException; | ||
| import org.apache.falcon.FalconRuntimException; | ||
| import org.apache.falcon.entity.v0.Entity; | ||
| import org.apache.falcon.resource.APIResult; | ||
| import org.apache.falcon.resource.channel.Channel; | ||
| import org.apache.falcon.resource.channel.ChannelFactory; | ||
| import org.apache.falcon.util.DeploymentUtil; | ||
|
|
||
| import javax.servlet.http.HttpServletRequest; | ||
| import java.util.HashMap; | ||
| import java.util.HashSet; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| import static org.apache.falcon.resource.AbstractEntityManager.getAllColos; | ||
| import static org.apache.falcon.resource.AbstractEntityManager.getApplicableColos; | ||
| import static org.apache.falcon.resource.proxy.SchedulableEntityManagerProxy.FALCON_TAG; | ||
|
|
||
| class EntityProxyUtil { | ||
| private final Map<String, Channel> entityManagerChannels = new HashMap<>(); | ||
| private final Map<String, Channel> configSyncChannels = new HashMap<>(); | ||
|
|
||
| EntityProxyUtil() { | ||
| try { | ||
| Set<String> colos = getAllColos(); | ||
|
|
||
| for (String colo : colos) { | ||
| initializeFor(colo); | ||
| } | ||
|
|
||
| DeploymentUtil.setPrismMode(); | ||
| } catch (FalconException e) { | ||
| throw new FalconRuntimException("Unable to initialize channels", e); | ||
| } | ||
| } | ||
| private void initializeFor(String colo) throws FalconException { | ||
| entityManagerChannels.put(colo, ChannelFactory.get("SchedulableEntityManager", colo)); | ||
| configSyncChannels.put(colo, ChannelFactory.get("ConfigSyncService", colo)); | ||
| } | ||
|
|
||
| Channel getConfigSyncChannel(String colo) throws FalconException { | ||
| if (!configSyncChannels.containsKey(colo)) { | ||
| initializeFor(colo); | ||
| } | ||
| return configSyncChannels.get(colo); | ||
| } | ||
|
|
||
| Channel getEntityManager(String colo) throws FalconException { | ||
| if (!entityManagerChannels.containsKey(colo)) { | ||
| initializeFor(colo); | ||
| } | ||
| return entityManagerChannels.get(colo); | ||
| } | ||
|
|
||
| Map<String, APIResult> proxySubmit(final String type, final HttpServletRequest bufferedRequest, | ||
| final Entity entity, final Set<String> colos) { | ||
| Map<String, APIResult> results = new HashMap<>(); | ||
| results.put(FALCON_TAG, new EntityProxy(type, entity.getName()) { | ||
| @Override | ||
| protected Set<String> getColosToApply() { | ||
| return colos; | ||
| } | ||
|
|
||
| @Override | ||
| protected APIResult doExecute(String colo) throws FalconException { | ||
| return getConfigSyncChannel(colo).invoke("submit", bufferedRequest, type, colo); | ||
| } | ||
| }.execute()); | ||
| return results; | ||
| } | ||
|
|
||
| Map<String, APIResult> proxyUpdate(final String type, final String entityName, final Boolean skipDryRun, | ||
| final HttpServletRequest bufferedRequest, Entity newEntity) { | ||
| final Set<String> oldColos = getApplicableColos(type, entityName); | ||
| final Set<String> newColos = getApplicableColos(type, newEntity); | ||
| final Set<String> mergedColos = new HashSet<>(); | ||
| mergedColos.addAll(oldColos); | ||
| mergedColos.retainAll(newColos); //Common colos where update should be called | ||
| newColos.removeAll(oldColos); //New colos where submit should be called | ||
| oldColos.removeAll(mergedColos); //Old colos where delete should be called | ||
|
|
||
| Map<String, APIResult> results = new HashMap<>(); | ||
| if (!oldColos.isEmpty()) { | ||
| results.put(FALCON_TAG + "/delete", new EntityProxy(type, entityName) { | ||
| @Override | ||
| protected Set<String> getColosToApply() { | ||
| return oldColos; | ||
| } | ||
|
|
||
| @Override | ||
| protected APIResult doExecute(String colo) throws FalconException { | ||
| return getConfigSyncChannel(colo).invoke("delete", bufferedRequest, | ||
| type, entityName, colo); | ||
| } | ||
| }.execute()); | ||
| } | ||
|
|
||
| if (!mergedColos.isEmpty()) { | ||
| results.put(FALCON_TAG + "/update", new EntityProxy(type, entityName) { | ||
| @Override | ||
| protected Set<String> getColosToApply() { | ||
| return mergedColos; | ||
| } | ||
|
|
||
| @Override | ||
| protected APIResult doExecute(String colo) throws FalconException { | ||
| return getConfigSyncChannel(colo).invoke("update", bufferedRequest, | ||
| type, entityName, | ||
| colo, skipDryRun); | ||
| } | ||
| }.execute()); | ||
| } | ||
|
|
||
| if (!newColos.isEmpty()) { | ||
| results.put(FALCON_TAG + "/submit", new EntityProxy(type, entityName) { | ||
| @Override | ||
| protected Set<String> getColosToApply() { | ||
| return newColos; | ||
| } | ||
|
|
||
| @Override | ||
| protected APIResult doExecute(String colo) throws FalconException { | ||
| return getConfigSyncChannel(colo).invoke("submit", bufferedRequest, type, | ||
| colo); | ||
| } | ||
| }.execute()); | ||
| } | ||
| return results; | ||
| } | ||
| } |
Oops, something went wrong.