review comments changes

pallavi-rao · Feb 9, 2017 · 917d3d5 · 917d3d5
1 parent e73e97d
commit 917d3d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/client/src/main/java/org/apache/falcon/client/FalconClient.java b/client/src/main/java/org/apache/falcon/client/FalconClient.java
@@ -1027,8 +1027,7 @@ public APIResult enumerateExtensions()  {
     @Override
     public ExtensionJobList getExtensionJobs(String extensionName, String sortOrder, String doAsUser) {
         ClientResponse clientResponse = new ResourceBuilder()
-                .path(ExtensionOperations.LIST.path)
-                .addQueryParam(EXTENSION_NAME_OPT, extensionName)
+                .path(ExtensionOperations.LIST.path, extensionName)
                 .addQueryParam(DO_AS_OPT, doAsUser)
                 .addQueryParam(SORT_ORDER, sortOrder)
                 .call(ExtensionOperations.LIST);

diff --git a/prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java b/prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java
@@ -94,10 +94,10 @@ public class ExtensionManagerProxy extends AbstractExtensionManager {
 
     //SUSPEND CHECKSTYLE CHECK ParameterNumberCheck
     @GET
-    @Path("list")
+    @Path("list{extension-name : (/[^/]+)?}")
     @Produces({MediaType.TEXT_XML, MediaType.APPLICATION_JSON})
     public ExtensionJobList getExtensionJobs(
-            @QueryParam("extension-name") String extensionName,
+            @PathParam("extension-name") String extensionName,
             @DefaultValue(ASCENDING_SORT_ORDER) @QueryParam("sortOrder") String sortOrder,
             @DefaultValue("") @QueryParam("doAs") String doAsUser) {
         checkIfExtensionServiceIsEnabled();