Fix codeq lookup of qualified symbols

pallet · Nov 30, 2012 · e18a25a · e18a25a
1 parent eb61172
commit e18a25a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/nrepl-codeq/src/ritz/nrepl/middleware/codeq.clj b/nrepl-codeq/src/ritz/nrepl/middleware/codeq.clj
@@ -44,7 +44,7 @@
   "Reply to codeq-def message"
   [{:keys [project symbol ns datomic-url transport] :as msg}]
   (try
-    (let [symbol (if (and symbol ns (.contains symbol "/"))
+    (let [symbol (if (or (and symbol (.contains symbol "/")) (not ns))
                    symbol
                    (str ns "/" symbol))
           res (query-definitions symbol datomic-url)]

diff --git a/nrepl-codeq/test/ritz/nrepl/middleware/codeq_test.clj b/nrepl-codeq/test/ritz/nrepl/middleware/codeq_test.clj
@@ -137,6 +137,16 @@ on the given transport with the handler, until the atom is set to false."
               :id 0}
              (.take out)))
 
+      (is (= #{:done} (:status (.take out))))
+
+      (.offer in {:op "codeq-def" :symbol "trace" :ns "ritz.logging"
+                  :datomic-url (datomic-url) :id 0})
+      (is (= {:value
+              [["(defmacro trace\n  [fmt-str & args]\n  `(log :trace ~fmt-str ~@args))"
+                "Sun Jul 03 02:08:35 UTC 2011"]]
+              :id 0}
+             (.take out)))
+
       ;; shut down the handle loop
       (reset! a false)
       (.offer in {:op "something to stop the handle loop"}))))