Merge pull request #218 from ThiefMaster/patch-1

Fix add() in RedisCache without a timeout
pallets-eco · Feb 17, 2021 · b5fa578 · b5fa578
2 parents f1899bc + 8560521
commit b5fa578
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/flask_caching/backends/rediscache.py b/flask_caching/backends/rediscache.py
@@ -135,11 +135,14 @@ def set(self, key, value, timeout=None):
     def add(self, key, value, timeout=None):
         timeout = self._normalize_timeout(timeout)
         dump = self.dump_object(value)
-        return self._write_client.setnx(
+        created = self._write_client.setnx(
             name=self._get_prefix() + key, value=dump
-        ) and self._write_client.expire(
-            name=self._get_prefix() + key, time=timeout
         )
+        if created and timeout != -1:
+            self._write_client.expire(
+                name=self._get_prefix() + key, time=timeout
+            )
+        return created
 
     def set_many(self, mapping, timeout=None):
         timeout = self._normalize_timeout(timeout)