Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: make cached view function make_cache_key attr writeable #431

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

snarfed
Copy link
Contributor

@snarfed snarfed commented Dec 26, 2022

fixes #97. this matches how memoize already does the same thing:

cache_key = decorated_function.make_cache_key(f, *args, **kwargs)

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • N/A Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • N/A Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

fixes pallets-eco#97. this matches how memoize already does the same thing on line 839:

  cache_key = decorated_function.make_cache_key(f, *args, **kwargs)
snarfed added a commit to snarfed/bridgy-fed that referenced this pull request Dec 26, 2022
Copy link
Member

@northernSage northernSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @snarfed

@northernSage northernSage merged commit 580ee60 into pallets-eco:master Jan 12, 2023
snarfed added a commit to snarfed/bridgy-fed that referenced this pull request Jan 12, 2023
snarfed added a commit to snarfed/oauth-dropins that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

make_cache_key in @cached is not working
2 participants