Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gzip response #154

Merged
merged 2 commits into from Aug 14, 2020
Merged

Support gzip response #154

merged 2 commits into from Aug 14, 2020

Conversation

zaw007
Copy link
Contributor

@zaw007 zaw007 commented Jun 6, 2020

If gzip is set in the header of the response, the flag will fail and the debugtoolbar will fail. This PR enables the extension to support the response with gizp.
Fixes #124 and #83 .

@jeffwidman jeffwidman merged commit 83d398d into pallets-eco:master Aug 14, 2020
@jeffwidman
Copy link
Member

Thanks!

@jace
Copy link

jace commented Jul 15, 2021

Could you release this to PyPI please? The last release of 0.11.0 from Feb 2020 doesn’t have this fix.

jeffwidman added a commit that referenced this pull request Oct 13, 2023
The `''` arg specifies a custom default value if the key isn't found. However, the default of `None` works fine for boolean testing:

```python
>>> 'gzip' in [None]
False
```

I missed this when I originally reviewed #154.
jeffwidman added a commit that referenced this pull request Oct 13, 2023
The `''` arg specifies a custom default value if the key isn't found. However, the default of `None` works fine for boolean testing:

```python
>>> 'gzip' in [None]
False
```

I missed this when I originally reviewed #154.
jeffwidman added a commit that referenced this pull request Oct 13, 2023
The `''` arg specifies a custom default value if the key isn't found. However, the default of `None` works fine for boolean testing:

```python
>>> 'gzip' in [None]
False
```

I missed this when I originally reviewed #154.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Case insensitive rfind is error prone.
3 participants