fix: drop response.charset because charset deprecated #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Thanks.
I took a quick peek at upstream to see if this has any backwards-breaking issues whereby we'd need to check the werkzeug version, but from my reading it looks it should be fine most of the time.
Also, this was deprecated back in April's 2.3.0 release and then removed in the recent 3.0.0 release, so I suspect most of our userbase will have already migrated to those versions.
More context:
amCap1712
added a commit
to amCap1712/flask-debugtoolbar
that referenced
this pull request
Oct 30, 2023
pallets-eco#206 fixed this partially but one instance slipped through. werkzueg is using utf-8 now for most places, encode the response to that encoding always without checking for response.charset.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next release of Werkzeug will drop response.charset.