fix: use urllib.parse.quote_plus and drop werkzeug.urls.url_quote_plus #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, hopefuly it gets approved soon |
Thank you! |
nickjj
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
I'll admit I didn't run this locally to confirm it works but conceptually this looks good to go. Since it's now being imported from Python's urllib library it'll be backwards compatible with both old and new versions of werkzeug. As long as the functionality of this function is the same we don't need to worry about this change breaking FDT.
Unless anyone has any objections, I'll merge this later today. I'll let it stay unmerged to give folks time to react.
|
Thanks for fixing this! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
werkzeug.urls.url_quote_plus is dropped from werkzeug==3.0.0