Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard Python gitignore file #220

Merged
merged 1 commit into from Nov 21, 2023
Merged

Use standard Python gitignore file #220

merged 1 commit into from Nov 21, 2023

Conversation

greyli
Copy link
Member

@greyli greyli commented Nov 17, 2023

jeffwidman
jeffwidman approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@jeffwidman
Copy link
Member

Hey, you write awesome PR descriptions. However, you don't include those descriptions in the commits, so when I go to squash merge, the default is an empty commit... do you mind updating your commits to include the descriptions?

Easy enough to do with a git commit --amend to edit a commit's description followed by force-pushing the new updated commit.

@jeffwidman jeffwidman merged commit 1aedfb0 into pallets-eco:master Nov 21, 2023
10 checks passed
@greyli
Copy link
Member Author

greyli commented Nov 21, 2023

Thanks, I will take care of that next time. Bad habit...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greyli @jeffwidman