Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal test without extra deps #230

Merged
merged 1 commit into from Dec 11, 2023

Conversation

greyli
Copy link
Member

@greyli greyli commented Dec 10, 2023

To prevent issues like #225, This PR add a minimal test that no extra deps are involved, it only install the package, then try to import the extension class.

fixes #226

To prevent issues like pallets-eco#225,
This PR add a minimal test that no extra deps are involved, it only install
the package, then try to import the extension class.

fixes pallets-eco#226
@greyli greyli changed the title Add minimal test Add minimal test without extra deps Dec 10, 2023
Copy link
Contributor

@macnewbold macnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@macnewbold macnewbold merged commit 8c8b2bb into pallets-eco:master Dec 11, 2023
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a basic integration test that ensures the python package is installable
2 participants