remove __version__
#260
Merged
remove __version__
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
deprecate-version
branch
from
b2f6dd0
to
cf69fb7
Compare
jeffwidman
approved these changes
Apr 30, 2024
|
I've removed |
davidism
force-pushed
the
deprecate-version
branch
from
efb7706
to
a0ccd43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__version__attribute is an old pattern from early in Python packaging. Setuptools eventually made it easier to use the pattern by allowing reading the value from the attribute at build time, and some other build backends have done the same.However, there's no reason to expose this directly in code anymore. It's usually easier to use feature detection (
hasattr,try/except) instead.importlib.metadata.version("flask-debugtoolbar")can be used to get the version at runtime in a standard way, if it's really needed.This matches what we've already done in the Pallets projects.